Promisy fun #110
Merged
Promisy fun #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groovecoder
requested changes
Apr 15, 2017
| combined tasks: | ||
| * gulp dev-packed - creates addon packages and watches for changes | ||
| * gulp dev-unpacked - creates directories with addon files and watches all for changes | ||
| 3. See the list of gulp tasks build or watch changes to files and compile extensions: |
Member
There was a problem hiding this comment.
With dev tasks removed from the doc, we need to change the lines below that say "Run one of the dev-___ tasks above".
| } | ||
| javascript_src = function({source, destination}) { | ||
| return function() { | ||
| console.log(`gather src ${source}/*.js files`) |
Member
There was a problem hiding this comment.
Wow, my vim syntax highlighter hates this /* part now. It thinks that it's commenting out the entire file after this.
src/issue.js
Outdated
| scrolling: "no", | ||
| seamless: "seamless" | ||
| } | ||
| const make_widget_appender = (domain) => { |
Member
There was a problem hiding this comment.
Is there a rhyme or reason for using arrow functions vs. declared functions? (e.g., make_widget_appender vs. on_github_pages)
Member
Author
There was a problem hiding this comment.
artistic license? Actually, I'm settling on named functions if it longer than one line.
| #### publish-{browser}-file | ||
| * **publish-firefox-file**: create xpi for FF prod | ||
| * **publish-chrome-file**: create zip for chrome and opera | ||
| * **publish-all**: creates all browser extension files |
Member
There was a problem hiding this comment.
When I try to run any of these gulp tasks, I get:
Error: Task requires a name that is a string
at Gulp.Orchestrator.add (/Users/lcrouch/code/codesy/widgets/node_modules/orchestrator/index.js:41:10)
at Object.<anonymous> (/Users/lcrouch/code/codesy/widgets/gulpfile.js:146:10)
at Module._compile (module.js:573:32)
at Object.Module._extensions..js (module.js:582:10)
at Module.load (module.js:490:32)
at tryModuleLoad (module.js:449:12)
at Function.Module._load (module.js:441:3)
at Module.require (module.js:500:17)
at require (internal/module.js:20:19)
at Liftoff.handleArguments (/usr/local/lib/node_modules/gulp/bin/gulp.js:116:3)
Member
|
Still getting errors during gulp ... |
Member
Author
|
hmm? |
groovecoder
requested changes
Apr 15, 2017
src/on_install.js
Outdated
| } | ||
|
|
||
| when_installed = ({reason}) => { | ||
| when_installed ({reason}) => { |
Member
There was a problem hiding this comment.
needs to be:
function when_installed({reason}) {
...
}
groovecoder
approved these changes
Apr 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another refactor to speed up load time. It work but comes with a recursive promise chain -- looking forward to a good discussion before merging.