fix(wp-migration): parse table_prefix correctly (v0.0.1.3)#26
Merged
Conversation
The previous parser used `sed "s/.*'//; s/'.*//"` which is greedy: for
a normal line `$table_prefix = 'wp_';`, the first sed matches up to and
including the closing single-quote, leaving just `;`. This broke step
6 silently — the URL-update query became `SELECT ... FROM ;options`,
mysql errored out under suppressed stderr, and the staging URL never
applied to the destination database.
Switch to `awk -F"'" '/^\$table_prefix[[:space:]]*=/ {print $2; exit}'`
which is robust against whitespace variants and unaffected by the
greedy-matching pitfall. Add empty-check and `[A-Za-z0-9_]+` validation
since the prefix is interpolated unquoted into SQL during step 6.
Bumps VERSION to 0.0.1.3.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$table_prefixparser withawk -F"'". The old code returned;for a normal$table_prefix = 'wp_';line.[A-Za-z0-9_]+validation since the prefix gets interpolated unquoted into SQL during step 6.Closes #25.
Verified parsing across formats
Test plan
bash -n wp-migration.shpasses🤖 Generated with Claude Code