Skip to content

Consider changing non-font related properties to px #6

@ddamato

Description

@ddamato

In the recent livestream, I noticed that many of the spacing values were set using rem. The issue with using rem (or any unit related to font-size) is that if the user increases the font size for their OS, this will also increase the space between elements. The purpose for folks increasing their font-size is for readability. If the OS font-size increases this will cause the spacing to also become large, most likely in an unhelpful way. Josh Comeau has an excellent blog post that goes into more detail.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions