Skip to content

Fixed undefined dom error. #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benmerckx merged 2 commits into from
May 9, 2022
Merged

Fixed undefined dom error. #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3e1f13
Fixed undefined dom error. https://sentry.io/organizations/codeurs-bv…
cloetensbrecht May 9, 2022
6a2c079
Simplified
cloetensbrecht May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/carousel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ type Snaps = {pages: Array<number>; elements: Array<number>}

export const useCarousel = (options?: CarouselOptions) => {
const [, gen] = useState(0)
const forceUpdate = useCallback(() => gen(x => x + 1), [gen])
const forceUpdate = useCallback(() => gen((x) => x + 1), [gen])
const [current, setCurrent] = useState(0)
const [total, setTotal] = useState(0)
const target = useRef(0)
Expand All @@ -63,7 +63,7 @@ export const useCarousel = (options?: CarouselOptions) => {
const goPrevious = () => goTo(current - 1)
return {
current,
setCurrent: current => {
setCurrent: (current) => {
setCurrent(current)
forceUpdate()
},
Expand All @@ -88,6 +88,7 @@ const mix = calc.getValueFromProgress
const MY_RETINA_FIXING_MAGIC_NUMBER = 3

const calcSnaps = (dom: HTMLDivElement) => {
if (!dom) return null
const pageWidth = dom.offsetWidth
const children = Array.from(
(dom.firstChild! as HTMLDivElement).children
Expand Down Expand Up @@ -173,6 +174,7 @@ export const Carousel: FunctionComponent<
const update = useCallback((force?: boolean) => {
const snaps = snapsRef.current
const newSnaps = calcSnaps(dom.current!)
if (!newSnaps) return
if (!force && snapKey(snaps) === snapKey(newSnaps)) return
setTotal(Math.ceil(newSnaps.pages.length))
snapsRef.current = newSnaps
Expand Down Expand Up @@ -260,10 +262,7 @@ export const Carousel: FunctionComponent<
x: start,
preventDefault: false
})
.pipe(
(pos: {x: number}) => pos.x,
overDrag
)
.pipe((pos: {x: number}) => pos.x, overDrag)
.start(offset).stop
listen(document, 'mouseup touchend', {once: true}).start(() =>
snapToPoint(start)
Expand Down Expand Up @@ -353,7 +352,7 @@ export const Carousel: FunctionComponent<
>
<div
style={{height: '100%', display: 'flex'}}
onDragStart={e => e.preventDefault()}
onDragStart={(e) => e.preventDefault()}
>
{children}
</div>
Expand Down