Skip to content

Conversation

@DanielKuhn
Copy link
Contributor

REDMINE-17585

@coveralls
Copy link

coveralls commented Apr 27, 2020

Coverage Status

Coverage increased (+0.001%) to 99.205% when pulling 87cc09e on DanielKuhn:audio-and-video-in-ci into 2c4443c on codevise:master.

"medium" => true,
"high" => true,
"low" => true
})
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/IndentHash: Indent the right brace the same as the first position after the preceding left parenthesis.

"hls-low" => true,
"medium" => true,
"high" => true,
"low" => true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

"dash-low" => true,
"hls-low" => true,
"medium" => true,
"high" => true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

"hls-high" => true,
"dash-low" => true,
"hls-low" => true,
"medium" => true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

"dash-high" => true,
"hls-high" => true,
"dash-low" => true,
"hls-low" => true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

"hls-playlist" => true,
"dash-medium"=> true,
"hls-medium" => true,
"dash-high" => true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

"dash-playlist" => true,
"hls-playlist" => true,
"dash-medium"=> true,
"hls-medium" => true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

file.update!(output_presences: {
"dash-playlist" => true,
"hls-playlist" => true,
"dash-medium"=> true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Layout/SpaceAroundOperators: Surrounding space missing for operator =>.

if file_type.eql?(:video)
file.update!(output_presences: {
"dash-playlist" => true,
"hls-playlist" => true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

file.update!(state: 'encoded')
if file_type.eql?(:video)
file.update!(output_presences: {
"dash-playlist" => true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/IndentHash: Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

Introduce .env variable to toggle transcoding during setup of scrolled entry
for CI/Percy
@DanielKuhn DanielKuhn force-pushed the audio-and-video-in-ci branch from 04b3c64 to d4e93cb Compare April 27, 2020 16:21
Describe the three-part-process required to use transcoded files in local storybook.
@tf tf merged commit 7c16e4d into codevise:master May 5, 2020
@tf tf added this to the v15.3 milestone Jul 7, 2020
@tf tf modified the milestone: v15.3 Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants