Skip to content

Fix dummy app generation with Thor 1.0 (15.2 Backport) #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tf merged 2 commits into from
Jul 15, 2020
Merged

Fix dummy app generation with Thor 1.0 (15.2 Backport) #1526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e32d4ef
Fix dummy app generation with Thor 1.0
tf Jul 13, 2020
67493ae
No longer pin chrome driver in scrolled Capybara specs
tf Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions entry_types/scrolled/spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
require 'pageflow/support/config/webmock'
require 'pageflow_scrolled'

# see REDMINE-17430
Webdrivers::Chromedriver.required_version = '79.0.3945.36'

RSpec.configure do |config|
# Enable flags like --only-failures and --next-failure
config.example_status_persistence_file_path = '.rspec_status'
Expand Down
3 changes: 1 addition & 2 deletions spec/support/pageflow/dummy/rails_template.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ def source_paths

# Recreate db. Ignore if it does not exist.

log :rake, 'db:drop:all'
in_root { run('rake db:environment:set db:drop:all 2> /dev/null', verbose: false) }
in_root { run('rake db:environment:set db:drop:all', capture: true, abort_on_failure: false) }
rake 'db:create:all'

# Install pageflow and the tested engine via their generators.
Expand Down