Fix use iframe height hook #1542
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataWrapperChart height was fixed previously to a static value It receives a post message from DataWrapper with the ideal height according to device It creates a hook, which register event and listen to the messages from iframe and ajust the height accordingly
It adds a spec to confirm that the registered event window is successfully removed It also changes the absolute path, change the testUrl to a dummy url and cleans the code
awaismbajwa
force-pushed
the
fix-useIframeHeightHook
branch
from
ae65bc9 to
902f17b
Compare
Contributor
|
Thanks for pushing the sample. Closing now, consolidated PR is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REDMINE-17670