Theme specific navigation logo for scrolled entries #1554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tf
changed the title
tf
force-pushed
the
themes
branch
3 times, most recently
from
ffdcf51 to
fa15d94
Compare
Paged and Scrolled entries will have different themes available and will support different theme options. REDMINE-17775
Copy default theme to host application when installing Pageflow Scrolled. Include theme asset paths and theme options in the seed data. Generating the entry JSON seed now requires Webpacker to be installed. We thefore need to run the Pageflow Scrolled install generator when generating the dummy app which is used to run the storybook seed task. REDMINE-17775
Reusable hook to access thene asset paths and options from seed config.
Replace hard coded image with file that can be supplied by host application. REDMINE-17775
tf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REDMINE-17775