Skip to content

Replace hard coded title and meta tags #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tf merged 1 commit into from
Oct 26, 2020
Merged

Replace hard coded title and meta tags #1593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions entry_types/scrolled/app/controllers/pageflow_scrolled/entries_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ module PageflowScrolled
class EntriesController < ActionController::Base
include Pageflow::EntriesControllerEnvHelper

helper Pageflow::EntriesHelper
helper Pageflow::WidgetsHelper
helper Pageflow::SocialShareHelper
helper Pageflow::MetaTagsHelper
Expand Down
9 changes: 3 additions & 6 deletions entry_types/scrolled/app/views/pageflow_scrolled/entries/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,13 @@
<!DOCTYPE html>
<%= content_tag(:html, lang: I18n.locale) do %>
<head>
<title><%= pretty_entry_title(@entry) %></title>

<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, height=device-height, initial-scale=1.0, minimum-scale=1.0, maximum-scale=1.0, user-scalable=no">
<meta name="theme-color" content="#000000" />
<meta
name="description"
content="Pageflow Next Showcase"
/>

<link href="https://fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,700&display=swap" rel="stylesheet">
<title>Pageflow Next Showcase</title>

<%= social_share_meta_tags_for(@entry) %>
<%= meta_tags_for_entry(@entry) %>

Expand Down