Merged
Conversation
Clicking the comment badge on a content element opens a bubble displaying all threads with their comments. The ThreadList component renders author names and comment text, filtered by subject. REDMINE-21261
Threads with replies collapse when multiple threads exist, showing reply count with an avatar stack of unique authors. Clicking expands to reveal all replies. Comments display author avatar with hue derived from name, formatted date, and body text indented past the avatar. REDMINE-21261
Previewers can create a new comment thread with an initial comment on a content element. The ReviewSession posts to the API, the ReviewMessageHandler routes the postMessage, and the NewThreadForm collects user input. REDMINE-21261
Render CSRF meta tags in the entry preview when commenting is enabled so the review API can verify POST requests. The JS request helper reads the token from the meta tag and includes it in the X-CSRF-Token header. REDMINE-21261
Show the form automatically when no threads exist. When threads are present, show a "New topic" button that reveals the form on click. The form hides again after submission. REDMINE-21261
Add a reply form to each thread that shows a textarea and reveals a Send button with icon when text is entered. Replies are posted to the comments API and appended to the thread in the ReviewSession. REDMINE-21261
Add a chevron button to threads with replies for expand/collapse. REDMINE-21261
Split the content element commenting overlay into three focused components: FloatingAnchor positions a portal relative to the element, Popover manages badge toggle and dismiss, ContentElementDecorator composes them. FloatingAnchor passes placement to Popover via render prop so it can control its own flex layout direction. REDMINE-21261
Let reviewers enter a mode where content elements become selectable for commenting. Selecting an element exits the mode, highlights the element with an accent border, opens the comment popover, and hides other badges to reduce clutter. Clicking outside or toggling the toolbar button dismisses the mode. REDMINE-21261
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REDMINE-21261