Split merge comment ranges#2410
Merged
tf merged 5 commits intocodevise:masterfrom Apr 28, 2026
Merged
Conversation
Structural ops that go through `Batch` (split, maybeMerge) now carry comment thread range updates and subject_id migrations alongside the configuration changes. Move, delete and insert pass their `reviewSession` to Batch, which threads the resulting per-thread range shifts and target-element migrations into both the wire payload (`comment_thread_subject_ranges`, `migrate_comment_threads`) and the post-save `ReviewSession` state. Keeps thread highlights anchored to their characters as users insert, delete or move content elements between text blocks. REDMINE-21261
When the EditableText value is replaced externally — e.g. after a textBlock split or merge that migrated comment ranges through Batch — the live rangeRefs were anchored to the previous content, producing stale or missing highlights for one render. Reset them as the new value lands and let the post-render effect rebuild them against the new content. REDMINE-21261
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REDMINE-21261