Fix edge cases in inline comment range ref tracking#2414
Merged
tf merged 2 commits intocodevise:masterfrom May 7, 2026
Merged
Conversation
After a delete-merge migrated a thread to a path that didn't exist in the previous value, the highlight stopped tracking subsequent edits — the rebuild ran from `useCachedValue`'s `onReset` against the still-old `editor.children` (Slate's `<Slate>` only replaces them on the next render), so `isValidRange` skipped the migrated range and no rangeRef was created. `resetRangeRefs` now just drops the stale refs and arms a flag that a second effect consumes on the following render, by which point the value flip has landed. REDMINE-21261
The reviewSession state provider produces a new threads array on every session change, including the round-trip echo of a debounced save that carries the just-saved subjectRange. Tying the unref cleanup to that array unref'd the live rangeRef and rebuilt it at the saved position, snapping the highlight backward and discarding keystrokes the user made during the network round-trip. REDMINE-21261
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REDMINE-21261