Skip to content

Reusable content#306

Merged
hakalb merged 2 commits intomainfrom
cod-294-reusable-content
Apr 16, 2025
Merged

Reusable content#306
hakalb merged 2 commits intomainfrom
cod-294-reusable-content

Conversation

@hakalb
Copy link
Copy Markdown
Member

@hakalb hakalb commented Apr 16, 2025

closed cod-294, cod-321

@hakalb hakalb self-assigned this Apr 16, 2025
Copilot AI review requested due to automatic review settings April 16, 2025 11:32
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 36 out of 38 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • apps/cms/src/app/(frontend)/globals.css: Language not supported
  • apps/web/app/tailwind.css: Language not supported
Comments suppressed due to low confidence (2)

libs/app-cms/ui/blocks/src/lib/card/card.block.ts:13

  • [nitpick] If the 'collectionCards' field is no longer used, consider removing it entirely from the block to avoid confusion.
// TODO: Not needed, replaced by reusable-content

libs/app-cms/ui/blocks/src/lib/card/card.block.ts:30

  • [nitpick] Consider providing a more descriptive name for 'customCards' to improve clarity, or remove this field if it is redundant with the reusable-content block.
// TODO: Refactor names

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 16, 2025

View your CI Pipeline Execution ↗ for commit 453fb81.

Command Status Duration Result
nx-cloud record -- nx format:check ✅ Succeeded 14s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-16 11:34:24 UTC

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3bb3b3f) to head (453fb81).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##             main      #306       +/-   ##
============================================
+ Coverage   81.08%   100.00%   +18.91%     
============================================
  Files          63         5       -58     
  Lines        1073        26     -1047     
  Branches      216         5      -211     
============================================
- Hits          870        26      -844     
+ Misses        203         0      -203     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codeware-actions
Copy link
Copy Markdown

✨ Your pull request projects are ready for preview

Project App name Preview
cms cdwr-cms-pr-306 https://cdwr-cms-pr-306.fly.dev
web cdwr-web-pr-306 https://cdwr-web-pr-306.fly.dev

@hakalb hakalb added this pull request to the merge queue Apr 16, 2025
Merged via the queue into main with commit 05cb8a5 Apr 16, 2025
17 checks passed
@hakalb hakalb deleted the cod-294-reusable-content branch April 16, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants