Skip to content

Creating and translating C kata #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hobovsky merged 28 commits into from
Jan 12, 2021
Merged

Creating and translating C kata #228

hobovsky merged 28 commits into from
Jan 12, 2021

Conversation

@hobovsky
Copy link
Contributor

@hobovsky hobovsky commented Jan 9, 2021 •
edited
Loading

Discussion: #207
Preview: here

I will create separate PRs for:

  • article on memory management pitfalls and practices,
  • abridged Criterion reference

@hobovsky hobovsky linked an issue Jan 9, 2021 that may be closed by this pull request
Create a guide for authoring in C #207
Closed
@hobovsky hobovsky requested review from a team and error256 January 10, 2021 15:37
@hobovsky hobovsky marked this pull request as ready for review January 10, 2021 15:37
@hobovsky hobovsky requested review from ggorlen and kazk January 10, 2021 17:35
Steffan153
Steffan153 suggested changes Jan 10, 2021
View reviewed changes
hobovsky and others added 2 commits January 10, 2021 21:46
@hobovsky @Steffan153
Apply suggestions from code review
676fcad 
Co-authored-by: Steffan <40404519+Steffan153@users.noreply.github.com>
@hobovsky @Steffan153
Apply suggestions from code review
15e069d 
Co-authored-by: Steffan <40404519+Steffan153@users.noreply.github.com>
@hobovsky hobovsky requested a review from Steffan153 January 10, 2021 21:18
Steffan153
Steffan153 suggested changes Jan 10, 2021
View reviewed changes
Copy link
Contributor

@Steffan153 Steffan153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welp

@hobovsky @Steffan153
Apply suggestions from code review
abe017c 
Co-authored-by: Steffan <40404519+Steffan153@users.noreply.github.com>
Steffan153
Steffan153 reviewed Jan 10, 2021
View reviewed changes
Steffan153
Steffan153 suggested changes Jan 11, 2021
View reviewed changes
@hobovsky @Steffan153
Apply suggestions from code review
95e3d39 
Co-authored-by: Steffan <40404519+Steffan153@users.noreply.github.com>
DonaldKellett
DonaldKellett requested changes Jan 11, 2021
View reviewed changes
hobovsky and others added 3 commits January 11, 2021 09:23
@hobovsky @DonaldKellett
Apply suggestions from code review
575f649 
Co-authored-by: Donald Sebastian Leung <donaldsebleung@gmail.com>
@hobovsky
Apply suggestions from code review
a7ddc0a
@hobovsky @DonaldKellett
Apply suggestions from code review
da56d5c 
Co-authored-by: Donald Sebastian Leung <donaldsebleung@gmail.com>
DonaldKellett
DonaldKellett reviewed Jan 11, 2021
View reviewed changes
DonaldKellett
DonaldKellett reviewed Jan 11, 2021
View reviewed changes
Copy link
Member

@DonaldKellett DonaldKellett left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the part regarding constants versus enums. resolved

kazk
kazk approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@kazk kazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for writing this.

error256
error256 requested changes Jan 12, 2021
View reviewed changes
@hobovsky hobovsky requested a review from error256 January 12, 2021 13:19
@hobovsky hobovsky merged commit 43bcb13 into master Jan 12, 2021
@hobovsky hobovsky deleted the authoring-c branch January 12, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazk kazk kazk approved these changes

@error256 error256 error256 approved these changes

@DonaldKellett DonaldKellett DonaldKellett approved these changes

@ggorlen ggorlen ggorlen approved these changes

+1 more reviewer

@Steffan153 Steffan153 Steffan153 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create a guide for authoring in C

7 participants

@hobovsky @kazk @error256 @DonaldKellett @ggorlen @Steffan153