-
Notifications
You must be signed in to change notification settings - Fork 0
test pr #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
test pr #2
Conversation
Activating Open Collective
I edited two typos in the readme-file.
fix(docs): edited typos in the documentation
README typo fix
When the window is resized, timeout(s) with setState are set; these need to be cleaned up on unmount to prevent a potential memory leak
Clear items to show resize timeout when component unmounts (Issue #87)
If the carousel is used in a form, the arrow button has type="submit" by default and sends the form. Added the type="button" to the buttons.
Follow pull-request #111 There should be notEnoughChildren if slidesToShow is equal to totalItems It allow to remove partialVisibilityGutter when there is the same count of items
Added button type for ArrowButton
Fix readme formatting
docs: add kuznetsovgm as a contributor
…onov docs: add VadimFilimonov as a contributor
Remove partialVisibilityGutter when totalItems is equal to slidesToShow
docs: add groomain as a contributor
Jir f feature/rtl
docs: add jir-f as a contributor for code
Incorrect breakpoint detection in chrome devtools
Clear timeouts on component unmount to prevent memory leaks
Update doc site
WalkthroughThe changes primarily involve the addition of multiple contributors to the Changes
Tip Early Access Features
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Outside diff range and nitpick comments (2)
.github/ISSUE_TEMPLATE/bug_report.md (2)
Line range hint
35-35: Remove consecutive blank lines to improve readability.-
Line range hint
18-18: Enhance readability by surrounding lists with blank lines.+ 1. Go to '...' 2. Click on '....' 3. Scroll down to '....' 4. See error +
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .all-contributorsrc (1 hunks)
- .github/ISSUE_TEMPLATE/bug_report.md (2 hunks)
- .gitignore (1 hunks)
Files skipped from review due to trivial changes (2)
- .all-contributorsrc
- .gitignore
Additional Context Used
Markdownlint (3)
.github/ISSUE_TEMPLATE/bug_report.md (3)
35: Expected: 1; Actual: 2
Multiple consecutive blank lines
18: null
Lists should be surrounded by blank lines
9: null
Emphasis used instead of a heading
| assignees: '' | ||
|
|
||
| --- | ||
| **Prerequisite** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a heading for better structure and visibility.
- **Prerequisite**
+ ## PrerequisiteCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| **Prerequisite** | |
| ## Prerequisite |
siva-levelops
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
siva-levelops
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chanGE THIS
| "contributions": [ | ||
| "code" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment 2
siva-levelops
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change it
| "profile": "https://github.com/donotcodeit", | ||
| "contributions": [ | ||
| "code" | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
starting review
Summary by CodeRabbit
New Features
Bug Fixes
Chores
.gitignoreto exclude the.ideadirectory.