Popular cookies #35
Merged
Popular cookies #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Lay <30853424+totally-not-frito-lays@users.noreply.github.com>
not-fritos
commented
Nov 12, 2023
Member
Author
not-fritos
left a comment
not-fritos
left a comment
There was a problem hiding this comment.
Overall, the changes look good! It looks like there were two separate issues being linked together into this branch however (popular cookies: #13 #18) and (templating: #15 ). Better practice would have these separate topics in separate branches.
For now this isn't an issue, it's just bad git practice.
This was
linked to
issues
Nov 12, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue link
Closes #18, #13, and #15
Checklist before requesting a review