feat: Add success message to subscribe form#14
Conversation
Imran-imtiaz48
left a comment
There was a problem hiding this comment.
Your code efficiently handles both scroll-based element visibility and a form submission success message. However, there are a few improvements you could make. Since revealElementOnScroll isn't defined in this snippet, ensure it exists before attaching it to scroll and load events to avoid errors. For the form submission handler, consider adding a check to ensure .success-message exists before modifying its display property to prevent potential runtime errors. Additionally, using visibility: hidden and opacity with transitions could create a smoother fade-out effect instead of abruptly hiding the message. Overall, the code is functional but could be refined for better robustness and user experience.
codeCraft-Ritik
left a comment
There was a problem hiding this comment.
Great work! The implementation is clean and easy to understand.”
Summary:
This PR adds a success message to the subscription form in the footer to improve user feedback. After a user submits the form, a success message is displayed to confirm their subscription.
Changes Made:
<p class="success-message">) below the form.Testing:
Related Issue:
Closes #13