Severity: Minor (release process)
Source: PR #16 review (M4)
scripts/build_manifest.py:18-28 hardcodes the TARGETS list. New modules added to rune/review/ or rune/patches/ are silently skipped — the script only warns when a listed file is missing, not when an unlisted file exists.
Fix options
- Auto-discover via
git ls-files rune/review rune/cli rune/patches minus an excludes list.
- Or add a CI check:
python scripts/check_manifest_targets.py that fails if any tracked file matching rune/(review|patches)/*.py is not in TARGETS.
Also: declare tomli_w, jsonschema, pytest-asyncio in pyproject.toml dev extras (currently undeclared — fresh checkouts will ImportError).
Severity: Minor (release process)
Source: PR #16 review (M4)
scripts/build_manifest.py:18-28hardcodes the TARGETS list. New modules added torune/review/orrune/patches/are silently skipped — the script only warns when a listed file is missing, not when an unlisted file exists.Fix options
git ls-files rune/review rune/cli rune/patchesminus an excludes list.python scripts/check_manifest_targets.pythat fails if any tracked file matchingrune/(review|patches)/*.pyis not in TARGETS.Also: declare
tomli_w,jsonschema,pytest-asyncioinpyproject.tomldev extras (currently undeclared — fresh checkouts will ImportError).