Skip to content

Added sidebar toggler #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Y-k-Y merged 10 commits into from
Aug 27, 2022
Merged

Added sidebar toggler #214

Y-k-Y merged 10 commits into from
Aug 27, 2022

Conversation

@Y-k-Y
Copy link
Contributor

@Y-k-Y Y-k-Y commented Jul 18, 2022

Resolves #196

  • The shortcut is "CMD + SHIFT + S" since "+" character is not supported at shortcut package

@neSpecc
Copy link
Member

neSpecc commented Jul 20, 2022

The shortcut is "CMD + SHIFT + S" since "+" character is not supported at shortcut package

The shortcut should be "CMD + ." since it is the common shortcuts for hiding panels (Figma, Sketch, etc). The plus is not the key, just a joiner for combination of the CMD and the Dot

neSpecc
neSpecc requested changes Jul 20, 2022
View reviewed changes
neSpecc
neSpecc requested changes Jul 20, 2022
View reviewed changes
Copy link
Member

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Sidebar should be always visible on mobile layout independent on the collapsed state

image

@Y-k-Y
fix: fix visibility on mobile layout
6cd5d87 
* fix visibility on mobile layout
* change keyboard shortcut
* change css property
@Y-k-Y
Copy link
Contributor Author

Y-k-Y commented Jul 21, 2022

The shortcut is "CMD + SHIFT + S" since "+" character is not supported at shortcut package

The shortcut should be "CMD + ." since it is the common shortcuts for hiding panels (Figma, Sketch, etc). The plus is not the key, just a joiner for combination of the CMD and the Dot

Changed shortcut as "Ctrl + ."

@Y-k-Y
Copy link
Contributor Author

Y-k-Y commented Jul 21, 2022

The Sidebar should be always visible on mobile layout independent on the collapsed state

image

Fixed

@slaveeks
Copy link
Member

slaveeks commented Aug 2, 2022

Why shortcut contains Ctrl, but not CMD? CMD is more comfortable for Mac

@slaveeks
Copy link
Member

slaveeks commented Aug 2, 2022

Can we make several kinds of shortcut? For Windows and MacOS

neSpecc
neSpecc reviewed Aug 2, 2022
View reviewed changes
@neSpecc
Copy link
Member

neSpecc commented Aug 2, 2022 •
edited
Loading

  1. Shortcut does not works (tested in Safari, MacOS)
  2. Somethimes the animation blinks twice
Aug-02-2022.18-11-25.mp4

robonetphy
robonetphy requested changes Aug 3, 2022
View reviewed changes
@Y-k-Y
fix: fix shortcuts to support Mac
ca04604 
* fix shortcuts to support Mac
* add comment to explain properties
@Y-k-Y
Copy link
Contributor Author

Y-k-Y commented Aug 4, 2022

  1. Shortcut does not works (tested in Safari, MacOS)
  2. Somethimes the animation blinks twice

Aug-02-2022.18-11-25.mp4

I'll fix this issue tomorrow since i don't have mac now

@Y-k-Y
Copy link
Contributor Author

Y-k-Y commented Aug 10, 2022

  1. Shortcut does not works (tested in Safari, MacOS)
  2. Somethimes the animation blinks twice

Aug-02-2022.18-11-25.mp4

Fixed

robonetphy
robonetphy requested changes Aug 19, 2022
View reviewed changes
@Y-k-Y Y-k-Y requested a review from neSpecc August 19, 2022 05:05
@Y-k-Y Y-k-Y merged commit 09835e3 into main Aug 27, 2022
@nikmel2803 nikmel2803 deleted the feature/add-sidebar-toggler branch December 1, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neSpecc neSpecc neSpecc approved these changes

@robonetphy robonetphy robonetphy approved these changes

@nikmel2803 nikmel2803 Awaiting requested review from nikmel2803

@talyguryn talyguryn Awaiting requested review from talyguryn

@TatianaFomina TatianaFomina Awaiting requested review from TatianaFomina

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ui: add the sidebar toggle

4 participants

@Y-k-Y @neSpecc @slaveeks @robonetphy