feat: hide-sidebar-content-on-mobile #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y-k-Y
requested review from
TatianaFomina,
neSpecc,
nikmel2803,
robonetphy and
talyguryn
and removed request for
neSpecc
Contributor
This class is used here https://github.com/codex-team/codex.docs/blob/main/src/frontend/js/modules/sidebar.js#L234 It's a workaround preventing sidebar from jumping when applying collapsed sections state |
TatianaFomina
approved these changes
Sep 8, 2022
ilyamore88
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #234
Maybe we can remove unused
docs-sidebar__content--invisibleclass name insidebar.twig?