Skip to content

Autoupdater initial#169

Merged
talyguryn merged 13 commits intoversion2.0from
autoupdater-initial
May 15, 2018
Merged

Autoupdater initial#169
talyguryn merged 13 commits intoversion2.0from
autoupdater-initial

Conversation

@talyguryn
Copy link
Copy Markdown
Member

No description provided.

@talyguryn talyguryn changed the base branch from master to version2.0 April 20, 2018 17:48
Copy link
Copy Markdown
Member

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • исправить комментарии
  • приложить doc с инструкцией по загрузке билдов
  • сделать кастомную неблокирующую панель с предложением перезагрузить приложение

Comment thread src/codex-notes.js
// compileDebug: true
}, locals);

const updater = require('./updater');
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

задокументировать объект

Comment thread src/codex-notes.js Outdated
this.mainWindow = null;
}

checkForUpdates() {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

задокументировать метод

Comment thread src/codex-notes.js Outdated
type: 'info',
buttons: ['Restart', 'Later'],
// title: 'New version',
message: `CodeX Notes v${info.version} has been downloaded. Restart the application to apply the updates.`,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

расхардкодить название

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

номер версии ни о чем не говорит, нужно написать что это новая версия.;

The new version is available. Restart CodeX Notes to enjoy a new experience.

@talyguryn talyguryn merged commit 90f3a5c into version2.0 May 15, 2018
@talyguryn talyguryn deleted the autoupdater-initial branch May 15, 2018 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants