Add block tool name to block class wrapper#2302
Open
wmnnd wants to merge 3 commits intocodex-team:nextfrom
Open
Add block tool name to block class wrapper#2302wmnnd wants to merge 3 commits intocodex-team:nextfrom
wmnnd wants to merge 3 commits intocodex-team:nextfrom
Conversation
wmnnd
requested review from
TatianaFomina,
gohabereg,
ilyamore88 and
neSpecc
as code owners
neSpecc
reviewed
Mar 17, 2023
| * @returns {HTMLDivElement} | ||
| */ | ||
| private compose(): HTMLDivElement { | ||
| const wrapper = $.make('div', Block.CSS.wrapper) as HTMLDivElement, |
Member
There was a problem hiding this comment.
I'd suggest to use the data-tool attribute instead of class
Member
Could you provide some real examples? Why not using tools' class names? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the tool name to block wrapper elements. This makes it easy to apply custom styles to existing/third-party blocks where it’s not possible to add such classes to the block itself.
In the case of the paragraph block, this would mean that the block receives the
ce-block--type-paragraphclass in addition toce-block.I’ve found this change tremendously helpful when working on integrating Editor.js into Keila.