Fixed socket usage#187
Merged
Merged
Conversation
neSpecc
approved these changes
May 6, 2026
Reversean
force-pushed
the
fix/socket-constructor
branch
3 times, most recently
from
17d8927 to
742cad6
Compare
Since socket reconnection logic changed and its constructor too we should adapt usages. Also since HawkInitialSettings.reconnectionAttempts is not used anymore it marked as deprecated.
Reversean
force-pushed
the
fix/socket-constructor
branch
from
742cad6 to
633860e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since socket reconnection logic changed and its constructor too (#182) we should adapt usages.
Also since
HawkInitialSettings.reconnectionAttemptsis not used anymore it marked as deprecated.