fix(): redis never throws key does not exist#539
Merged
Conversation
neSpecc
approved these changes
Apr 1, 2026
Dobrunia
approved these changes
Apr 7, 2026
e11sy
added a commit
that referenced
this pull request
Apr 7, 2026
* feat(workers): catch-unhandled-exceptions (#532) * feat(workers): add decorator to catch unhandled exceptions and report them to Hawk with worker type context * fix lint * Revert "fix lint" This reverts commit 7a7c0a9. * Revert "feat(workers): add decorator to catch unhandled exceptions and report them to Hawk with worker type context" This reverts commit ebb1fd7. * refactor(runner): add active worker names to HawkCatcher context * fix(): redis never throws key does not exist (#539) --------- Co-authored-by: KoshaevEugeny <103786108+akulistus@users.noreply.github.com> Co-authored-by: e11sy <130844513+e11sy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
In redis time series keys were created without retention — that leads to memory leaks, since keys are never archived
Cause
from redis docs
so when we called
tsAddmethod and waited forTSDB: key does not existerror we did it wrongit never fires an error, but it automatically creates the key with retention 0 as we saw on stage
Solution
first — create key if not exists
second — increment key that was created with valid retention in the previous step