Skip to content

fix: Redirect to 404 Page When Note is Not Found#277

Merged
Tushar504 merged 18 commits intomainfrom
fix/redirect-when-note-is-not-found
Jan 25, 2025
Merged

fix: Redirect to 404 Page When Note is Not Found#277
Tushar504 merged 18 commits intomainfrom
fix/redirect-when-note-is-not-found

Conversation

@Tushar504
Copy link
Copy Markdown
Contributor

@Tushar504 Tushar504 commented Nov 16, 2024

@Tushar504 Tushar504 linked an issue Nov 16, 2024 that may be closed by this pull request
Redirect to 404 Page When Note is Not Found #276
Closed
@Tushar504 Tushar504 requested review from e11sy and neSpecc November 16, 2024 12:02
neSpecc
neSpecc reviewed Nov 16, 2024
View reviewed changes
Comment thread src/application/services/useNote.ts Outdated
@Tushar504 Tushar504 requested a review from neSpecc November 19, 2024 15:51
e11sy
e11sy reviewed Nov 19, 2024
View reviewed changes
Comment thread src/domain/entities/errors/ApiError.ts Outdated
Comment thread src/application/services/useNote.ts Outdated
@Tushar504 Tushar504 requested a review from e11sy November 20, 2024 16:28
e11sy
e11sy reviewed Nov 20, 2024
View reviewed changes
Comment thread src/application/router/routes.ts Outdated
@Tushar504 Tushar504 requested a review from e11sy November 28, 2024 18:16
e11sy
e11sy reviewed Dec 3, 2024
View reviewed changes
Comment thread src/domain/entities/errors/ApiError.ts Outdated
neSpecc
neSpecc reviewed Dec 4, 2024
View reviewed changes
Comment thread src/application/services/useNote.ts Outdated
@Tushar504 Tushar504 requested a review from neSpecc December 12, 2024 15:41
neSpecc
neSpecc reviewed Dec 14, 2024
View reviewed changes
Comment thread src/application/router/routes.ts Outdated
neSpecc
neSpecc reviewed Dec 25, 2024
View reviewed changes
Comment thread src/application/router/routes.ts Outdated
Comment thread src/presentation/pages/Error.vue Outdated
@Tushar504 Tushar504 requested a review from neSpecc December 26, 2024 09:02
neSpecc
neSpecc reviewed Dec 26, 2024
View reviewed changes
Comment thread src/presentation/pages/Error.vue Outdated
@Tushar504 Tushar504 requested review from e11sy and neSpecc December 26, 2024 15:00
neSpecc
neSpecc approved these changes Dec 26, 2024
View reviewed changes
Comment thread src/application/services/useNote.ts Outdated
e11sy
e11sy reviewed Jan 14, 2025
View reviewed changes
Comment thread src/application/services/useNote.ts
Comment thread src/presentation/pages/Error.vue
@Tushar504 Tushar504 requested review from e11sy and neSpecc January 15, 2025 17:57
neSpecc
neSpecc reviewed Jan 15, 2025
View reviewed changes
Comment thread src/domain/entities/errors/ApiError.ts Outdated
Comment thread src/infrastructure/transport/notes-api/index.ts Outdated
Comment thread src/infrastructure/transport/notes-api/index.ts Outdated
@neSpecc neSpecc self-requested a review January 15, 2025 19:52
e11sy
e11sy reviewed Jan 18, 2025
View reviewed changes
Comment thread src/application/services/useNote.ts Outdated
@Tushar504 Tushar504 requested a review from e11sy January 21, 2025 15:46
neSpecc
neSpecc reviewed Jan 22, 2025
View reviewed changes
Comment thread src/domain/entities/errors/Base.ts
Comment thread src/domain/entities/errors/NotFound.ts Outdated
@Tushar504 Tushar504 requested review from e11sy and neSpecc January 25, 2025 13:18
@Tushar504 Tushar504 merged commit cc3f109 into main Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neSpecc neSpecc neSpecc approved these changes

@e11sy e11sy e11sy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Redirect to 404 Page When Note is Not Found

3 participants

@Tushar504 @neSpecc @e11sy