Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Binance Bot
# Market Bot for Binance Exchange

_Naive Market Maker Bot for Binance._

Solution contains two console projects:
Expand All @@ -17,28 +18,35 @@ to _create real order_ in order book.


## Roadmap

#### Throlling

Binance has numerous limits to requests, orders count, min/max volume of order, etc. The networks restrictions should be taken into BinanceBot working as part of `BinanceClientConfiguration`,
and the orders restrictions - as part of `MarkerStrategyConfiguration`.

#### Security

Binance API keys should be stored in secured storage (such as `Azure Key Vault` service) instead of plain text such it is now.

#### Configurations

Any configuration (of connectors or bot) should be placed in separate configuration storage (such as `JSON files` in local file system).
This will allow you to reconfigure the bot without the need for recompilation.

#### Other

BinanceBot doesn’t processed network connection errors.
It would be to implement `Retry Policies` for the broken connections and handling other network errors.

The solution doesn’t contain any `Unit Tests`/`Integration Tests`, which is a bad practice.

## Requirements
__.NET Core 2.1__ (also compatible with .NET 4.5.1, .NET 4.5.2, .NET 4.6.1, .NETSTANDARD2.0).

- .NET Core 3.1.


## References

1. [Binance official API docs](https://github.com/binance-exchange/binance-official-api-docs).
2. [Official C# Wrapper for the Binance exchange API](https://github.com/glitch100/BinanceDotNet).

Expand Down
18 changes: 0 additions & 18 deletions source/BinanceBot.Market/BinanceBot.Market.csproj

This file was deleted.

This file was deleted.

12 changes: 12 additions & 0 deletions src/BinanceBot.Market/BinanceBot.Market.csproj
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netstandard2.1</TargetFramework>
<LangVersion>8.0</LangVersion>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\BinanceDotNet.BinanceExchange.API\BinanceDotNet.BinanceExchange.API.csproj" />
</ItemGroup>

</Project>
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp2.1</TargetFramework>
<Version>0.1.0</Version>
<TargetFramework>netcoreapp3.1</TargetFramework>
<Version>0.2.0</Version>
<Authors>Dmitry Petukhov</Authors>
<Product>BinanceBot</Product>
<Copyright>(c) 2018, Dmitry Petukhov.</Copyright>
<PackageProjectUrl>http://0xcode.in</PackageProjectUrl>
<Copyright>(c) 2020, Dmitry Petukhov.</Copyright>
<PackageProjectUrl>http://0xcode.in/</PackageProjectUrl>
<RepositoryUrl>https://github.com/codez0mb1e/BinanceBot</RepositoryUrl>
</PropertyGroup>

Expand All @@ -16,8 +16,8 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="NLog" Version="4.5.9" />
<PackageReference Include="NLog.Config" Version="4.5.9" />
<PackageReference Include="NLog" Version="4.7.5" />
<PackageReference Include="NLog.Config" Version="4.7.5" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp2.1</TargetFramework>
<Version>0.1.0</Version>
<TargetFramework>netcoreapp3.1</TargetFramework>
<Version>0.2.0</Version>
<Authors>Dmitry Petukhov</Authors>
<Product>BinanceBot</Product>
<Copyright>(c) 2018, Dmitry Petukhov.</Copyright>
<PackageProjectUrl>http://0xcode.in</PackageProjectUrl>
<Copyright>(c) 2020, Dmitry Petukhov.</Copyright>
<PackageProjectUrl>http://0xcode.in/</PackageProjectUrl>
<RepositoryUrl>https://github.com/codez0mb1e/BinanceBot</RepositoryUrl>
</PropertyGroup>

Expand All @@ -16,8 +16,8 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="NLog" Version="4.5.9" />
<PackageReference Include="NLog.Config" Version="4.5.9" />
<PackageReference Include="NLog" Version="4.7.5" />
<PackageReference Include="NLog.Config" Version="4.7.5" />
</ItemGroup>

<ItemGroup>
Expand Down
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netstandard2.1</TargetFramework>
<LangVersion>8.0</LangVersion>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
<PackageReference Include="NLog" Version="4.7.5" />
<PackageReference Include="System.Net.Http" Version="4.3.4" />
<PackageReference Include="WebSocketSharp-netstandard" Version="1.0.1" />
</ItemGroup>

</Project>