Skip to content

ACD - Added jline acceptable security exception#49

Merged
paouelle merged 3 commits intocodice:masterfrom
paouelle:ACD-XXX
Dec 5, 2018
Merged

ACD - Added jline acceptable security exception#49
paouelle merged 3 commits intocodice:masterfrom
paouelle:ACD-XXX

Conversation

@paouelle
Copy link
Copy Markdown
Collaborator

@paouelle paouelle commented Dec 3, 2018

Description of the Change

Added jline acceptable security exception to handle failure creating a system terminal which falls back to a dumb one.

Alternate Designs

None

Benefits

All DDF itests are reporting this failure which is an acceptable one. This will make the debugger report it as an acceptable one from now on.

Possible Drawbacks

None

Verification Process

Run DDF itests with this new debugger and see it reported as acceptable.

Applicable Issues

Fixes: #___

@paouelle paouelle self-assigned this Dec 3, 2018
@paouelle paouelle requested a review from AzGoalie December 3, 2018 15:50
@paouelle
Copy link
Copy Markdown
Collaborator Author

paouelle commented Dec 3, 2018

build now

…ating a system terminal which falls back to a dumb one
@paouelle
Copy link
Copy Markdown
Collaborator Author

paouelle commented Dec 3, 2018

build now

@cxbot
Copy link
Copy Markdown
Collaborator

cxbot commented Dec 3, 2018

Internal build has been started. Your results will be available at completion. See build progress in legacy Jenkins UI or in Blue Ocean UI.

@cxbot
Copy link
Copy Markdown
Collaborator

cxbot commented Dec 3, 2018

Build failure. See the job results in legacy Jenkins UI or in Blue Ocean UI.

@paouelle
Copy link
Copy Markdown
Collaborator Author

paouelle commented Dec 3, 2018

build now,
Seems like a hickup on SonarCloud

@cxbot
Copy link
Copy Markdown
Collaborator

cxbot commented Dec 3, 2018

Internal build has been started. Your results will be available at completion. See build progress in legacy Jenkins UI or in Blue Ocean UI.

@cxbot
Copy link
Copy Markdown
Collaborator

cxbot commented Dec 3, 2018

Build success! See the job results in legacy Jenkins UI or in Blue Ocean UI.

java\.io\.FilePermission ".*somaxconn", "read"
io\.netty\.util\.NetUtil\$.*:267

# At startup time, Karaf tries to create a system terminal and will fall back to a dumb one of it c
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"if it cannot".

java\.io\.FilePermission ".*somaxconn", "read"
io\.netty\.util\.NetUtil\$.*:267

# At startup time, Karaf tries to create a system terminal and will fall back to a dumb one of it c
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this context, what is the difference between a system terminal and a dumb [terminal]? Is a system terminal have rich text (colors, bolding, and so one) while a dumb terminal has no character formatting?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I don 't really know. I just know all our itests have always fallback to dumb terminal. But in this case, it ain't a security failure since the code is designed to handle this type of security exception.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But what is dumb terminal? That's what I'd like to know.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? This is what Karaf calls it ...

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. thanks.

@paouelle
Copy link
Copy Markdown
Collaborator Author

paouelle commented Dec 3, 2018

build now

@cxbot
Copy link
Copy Markdown
Collaborator

cxbot commented Dec 3, 2018

Internal build has been started. Your results will be available at completion. See build progress in legacy Jenkins UI or in Blue Ocean UI.

@cxbot
Copy link
Copy Markdown
Collaborator

cxbot commented Dec 3, 2018

Build success! See the job results in legacy Jenkins UI or in Blue Ocean UI.

java\.io\.FilePermission ".*somaxconn", "read"
io\.netty\.util\.NetUtil\$.*:267

# At startup time, Karaf tries to create a system terminal and will fall back to a dumb one of it
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There one type. The word "of" should be "if", here:

expected: "dumb one it it"
actual: "dumb one of it"

@paouelle
Copy link
Copy Markdown
Collaborator Author

paouelle commented Dec 5, 2018

build now

@cxbot
Copy link
Copy Markdown
Collaborator

cxbot commented Dec 5, 2018

Internal build has been started. Your results will be available at completion. See build progress in legacy Jenkins UI or in Blue Ocean UI.

@cxbot
Copy link
Copy Markdown
Collaborator

cxbot commented Dec 5, 2018

Build success! See the job results in legacy Jenkins UI or in Blue Ocean UI.

@paouelle paouelle merged commit cfa6174 into codice:master Dec 5, 2018
@paouelle paouelle deleted the ACD-XXX branch January 8, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants