Skip to content

DDFP-19 Upgraded jacoco, checkstyle, dependency-check#22

Merged
shaundmorris merged 2 commits intocodice:masterfrom
shaundmorris:jacoco
Apr 1, 2020
Merged

DDFP-19 Upgraded jacoco, checkstyle, dependency-check#22
shaundmorris merged 2 commits intocodice:masterfrom
shaundmorris:jacoco

Conversation

@shaundmorris
Copy link
Copy Markdown
Member

@shaundmorris shaundmorris commented Mar 18, 2020

Upgraded Dependency-check from 5.2.2 to 5.3.1
Upgraded Checkstyle from 3.0.0 to 3.1.1
Upgraded Jacoco from 0.8.2 to 0.8.5

Removed customized project report output directory

Fixes: #19

Reviewers
@codice/build
@codice/continuous-integration
@codice/test
@codice/security
@TonyMorrison
@LinkMJB
@AdamBurstynski

@shaundmorris shaundmorris requested a review from mcalcote March 18, 2020 23:28
Copy link
Copy Markdown
Collaborator

@mcalcote mcalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paouelle
Copy link
Copy Markdown
Contributor

paouelle commented Apr 1, 2020

❗️ Make sure that the Lenient limit class will still work with this new version of jacoco

@shaundmorris
Copy link
Copy Markdown
Member Author

Thanks for the reminder @paouelle. I did have to make some changes to the Lenient class and need a new release codice-maven as well. The DDF PR will have the latest ddf-parent and codice-maven so we can ensure it all works together.

@shaundmorris
Copy link
Copy Markdown
Member Author

I did run the SNAPSHOT versions locally and it passed, but we know how that goes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Plugins (Jacoco, Checkstyle, Dependency-check)

5 participants