Skip min title validation for help/policy posts#1197
Merged
Conversation
MoshiKoi
reviewed
Sep 1, 2023
Oaphi
approved these changes
Nov 11, 2023
Member
Oaphi
left a comment
Oaphi
left a comment
There was a problem hiding this comment.
Changes LGTM (I personally prefer ternary expressions, but my background mostly includes languages where you can't assign the result of evaluating the if...else directly anyway; as it passes rubocop, all good)
Contributor
Author
@Oaphi I was thinking about the options, but since we have 3 cases here ternary expressions seemed a bit much, and this if-else-end expression is what I had to do to make rubocop happy, so yeah 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeding was no longer creating help/policy posts with title lengths < 15, due to the recent validations changes. This PR excludes help and policy documents from the min title length requirement, to allow help articles like "FAQ" to be created again.