Make include_tags & exclude_tags params more robust#2011
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cellio
left a comment
There was a problem hiding this comment.
A valid filter URL is like this:
http://localhost:3000/categories/1?sort=&predefined_filter=&min_score=&max_score=&min_answers=&max_answers=&status=any&include_tags%5B%5D=8
I hand-edited that make include_tags have an invalid value, like this:
http://localhost:3000/categories/1?sort=&predefined_filter=&min_score=&max_score=&min_answers=&max_answers=&status=any&include_tags=%5B8%5D
On develop that causes a server error; on this branch it does not.
I don't know if we care, but with the invalid URL, it renders the category page as expected, but it shows with a filter applied but the tag is missing:
If there is no on-site way to create that malformed URL then I don't care, but I mention it in case there are other implications.
closes #2010