Skip to content

Make include_tags & exclude_tags params more robust#2011

Merged
ArtOfCode- merged 2 commits intodevelopfrom
0valt/2010/array-search-params
Mar 12, 2026
Merged

Make include_tags & exclude_tags params more robust#2011
ArtOfCode- merged 2 commits intodevelopfrom
0valt/2010/array-search-params

Conversation

@Oaphi
Copy link
Copy Markdown
Member

@Oaphi Oaphi commented Mar 11, 2026

closes #2010

@Oaphi Oaphi requested review from a team, ArtOfCode- and cellio March 11, 2026 15:44
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.73%. Comparing base (4deef91) to head (60bfc1f).
⚠️ Report is 15 commits behind head on develop.

Additional details and impacted files
Components Coverage Δ
controllers 75.82% <ø> (-0.04%) ⬇️
helpers 85.09% <100.00%> (+0.02%) ⬆️
jobs 66.88% <ø> (ø)
models 93.01% <ø> (ø)
tasks 61.11% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@cellio cellio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A valid filter URL is like this:

http://localhost:3000/categories/1?sort=&predefined_filter=&min_score=&max_score=&min_answers=&max_answers=&status=any&include_tags%5B%5D=8

I hand-edited that make include_tags have an invalid value, like this:

http://localhost:3000/categories/1?sort=&predefined_filter=&min_score=&max_score=&min_answers=&max_answers=&status=any&include_tags=%5B8%5D

On develop that causes a server error; on this branch it does not.

I don't know if we care, but with the invalid URL, it renders the category page as expected, but it shows with a filter applied but the tag is missing:

screenshot

If there is no on-site way to create that malformed URL then I don't care, but I mention it in case there are other implications.

@ArtOfCode- ArtOfCode- merged commit 3d890ef into develop Mar 12, 2026
13 checks passed
@ArtOfCode- ArtOfCode- deleted the 0valt/2010/array-search-params branch March 12, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

include_tags search filter sometimes fails to be parsed as an array

3 participants