Fix undefined secondary sort for user posts breaking pagination#2013
Merged
ArtOfCode- merged 2 commits intodevelopfrom Mar 12, 2026
Merged
Fix undefined secondary sort for user posts breaking pagination#2013ArtOfCode- merged 2 commits intodevelopfrom
ArtOfCode- merged 2 commits intodevelopfrom
Conversation
c2029e7 to
e2c2f6a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
This changed the number in the "see all" button on the profile from the true number back to 15 (for someone with more than 15, i.e. someone with pagination). |
Member
Author
ah, whoops, a sec |
cellio
reviewed
Mar 11, 2026
cellio
approved these changes
Mar 11, 2026
Member
cellio
left a comment
There was a problem hiding this comment.
LGTM now; tested and it's behaving correctly. Thanks for adding the test.
ArtOfCode-
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2008
This PR adds a secondary order by creation timestamp to user's posts (newest first) - this should be safe enough for 99.99% cases (creation timestamp collision is highly unlikely). In addition, the PR lays the groundwork for a proper action callback by making the logic for setting posts in the
showandpostsactions shared (that's as far as I am willing to go in scope for this particular fix).