Fix comment thread expansion if its title contains clickable elements#2037
Fix comment thread expansion if its title contains clickable elements#2037
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Let's do a production deployment upon review & merge |
cellio
left a comment
There was a problem hiding this comment.
Tested and works for me.
Before the fix, in a dev environment I got what looks like a stack trace rather than a 404, so I'm not sure how to test the "maybe also fixes" issue. But we can check that case after deploying this and see if it's still an issue.
That's the exact same error, @cellio, it's just that in development mode the |
closes #2036
Also makes sure we do not replace the inline thread with the fetched content unless the response indicates success (most likely solves meta:295715, but let's make sure every case is covered in a separate PR).
As a treat, it also ensures MathJax stays properly rendered upon collapsing previously opened comment threads.