Include post author in comment pings#2056
Merged
ArtOfCode- merged 3 commits intoMay 19, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
For prioritisation decisions, until this fix is deployed:
|
cellio
approved these changes
May 19, 2026
Member
cellio
left a comment
There was a problem hiding this comment.
LGTM. Tested to confirm the fixes listed in #2056 (comment) . I noticed that a post author pinged in a new comment thread now receives a notification for the pinging comment but not also the thread; this seems reasonable to me, as you're automatically being notified of the new thread indirectly and it would be too hard to say "new thread" in the notification in this case (and we don't want double notifications there).
ArtOfCode-
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2046.
In #1548 I neglected to remove 1 special case treatment of the post author, resulting in no notification when the post author is mentioned in a comment under their own post. This pull request adds a fix and tests.