Skip to content

Include post author in comment pings#2056

Merged
ArtOfCode- merged 3 commits into
developfrom
trichoplax/2046/pinging-post-author-blocks-comment-notification
May 19, 2026
Merged

Include post author in comment pings#2056
ArtOfCode- merged 3 commits into
developfrom
trichoplax/2046/pinging-post-author-blocks-comment-notification

Conversation

@trichoplax
Copy link
Copy Markdown
Contributor

@trichoplax trichoplax commented May 19, 2026

Fixes #2046.

In #1548 I neglected to remove 1 special case treatment of the post author, resulting in no notification when the post author is mentioned in a comment under their own post. This pull request adds a fix and tests.

@trichoplax trichoplax marked this pull request as draft May 19, 2026 11:41
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.85%. Comparing base (9c10754) to head (793c54a).

Additional details and impacted files
Components Coverage Δ
controllers 76.03% <100.00%> (-0.05%) ⬇️
helpers 85.31% <ø> (ø)
jobs 66.88% <ø> (ø)
models 93.04% <ø> (ø)
tasks 61.11% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trichoplax trichoplax marked this pull request as ready for review May 19, 2026 16:42
@trichoplax
Copy link
Copy Markdown
Contributor Author

For prioritisation decisions, until this fix is deployed:

  • A post author @ mentioned in a new thread will be notified of the new thread (but not the mention - this pull request fixes that).
  • A post author @ mentioned in a comment in an existing thread will not be notified at all (neither of the new comment nor of the mention - this pull request fixes that).
  • A post author not @ mentioned will be correctly notified of new threads and new comments.

@trichoplax trichoplax requested review from ArtOfCode-, Oaphi and cellio May 19, 2026 16:52
Copy link
Copy Markdown
Member

@cellio cellio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested to confirm the fixes listed in #2056 (comment) . I noticed that a post author pinged in a new comment thread now receives a notification for the pinging comment but not also the thread; this seems reasonable to me, as you're automatically being notified of the new thread indirectly and it would be too hard to say "new thread" in the notification in this case (and we don't want double notifications there).

@ArtOfCode- ArtOfCode- merged commit 8eeed62 into develop May 19, 2026
13 checks passed
@ArtOfCode- ArtOfCode- deleted the trichoplax/2046/pinging-post-author-blocks-comment-notification branch May 19, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lack of post author notification of a comment in a thread under their post

3 participants