Skip to content
This repository was archived by the owner on May 4, 2023. It is now read-only.

Conversation

@picimako
Copy link
Contributor

Changes

  • CodigaConfigFileUtil
    • Replaced the non-dynamic deserialization with a dynamic-typed one, so that extending the parsing for future functionalities becomes easier.
    • The direct deserialization into CodigaCodeAnalysisConfig is removed because with having the extended dynamic-typed one, it didn't make sense to keep it.
      • Related model classes are: CodigaCodeAnalysisConfig, RulesetIgnore, RuleIgnore
  • RosieRulesCache
    • Replaced the cached ruleset names with the deserialized CodigaCodeAnalysisConfig.
    • Renamed GetRosieRulesForLanguage() to GetRosieRules(), and added logic to filter the rules based on the ignore configuration and passed in path of the currently analyzed file.
  • Extracted the service provider and solution root dir retrieval into SolutionHelper.

@github-actions
Copy link

github-actions bot commented Jan 19, 2023

Test Results

    1 files  ±  0    30 suites  ±0   9s ⏱️ +3s
273 tests +36  265 ✔️ +36  8 💤 ±0  0 ±0 
278 runs  +36  270 ✔️ +36  8 💤 ±0  0 ±0 

Results for commit 023a38f. ± Comparison against base commit 9de28d4.

♻️ This comment has been updated with latest results.

@dastrong-codiga dastrong-codiga merged commit 196abcf into main Jan 19, 2023
@dastrong-codiga dastrong-codiga deleted the codiga-yaml-ignore branch January 19, 2023 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants