Skip to content

Conversation

@aggarwalpulkit596
Copy link
Contributor

@aggarwalpulkit596 aggarwalpulkit596 commented Aug 15, 2018

@codecov
Copy link

codecov bot commented Aug 15, 2018

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #108   +/-   ##
========================================
  Coverage      26.6%   26.6%           
  Complexity       33      33           
========================================
  Files            83      83           
  Lines          1887    1887           
  Branches         93      93           
========================================
  Hits            502     502           
  Misses         1347    1347           
  Partials         38      38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62dee3e...3f05262. Read the comment docs.

@aggarwalpulkit596
Copy link
Contributor Author

@championswimmer bhaiya it be merged it was pushed before 12

@championswimmer
Copy link
Contributor

you can fix the circle ci part in this PR itself, as you had done major work before deadline. minor fixes can be added to PRs. new claims cannot be made

@aggarwalpulkit596
Copy link
Contributor Author

@championswimmer i have made the claim already i will getting the 2000 points right ?

@aggarwalpulkit596
Copy link
Contributor Author

@championswimmer bhaiya circle 2.0 doesn't support emulators so we can't have instrumentation test right now
https://support.circleci.com/hc/en-us/articles/360000028928-Testing-with-Android-emulator-on-CircleCI-2-0

@championswimmer
Copy link
Contributor

oh, lets do only unit tests on circleci then

@championswimmer
Copy link
Contributor

@championswimmer i have made the claim already i will getting the 2000 points right ?

yes

@aggarwalpulkit596
Copy link
Contributor Author

i have updated circle to 2.0 will i be getting some extra points for that 📦 other than that 2000 points

@aggarwalpulkit596
Copy link
Contributor Author

aggarwalpulkit596 commented Aug 15, 2018

@championswimmer i think we can't do unit test as well :P
i tried running the tests locally and here what i got
screenshot 2018-08-16 at 1 08 03 am

@championswimmer
Copy link
Contributor

that's what you are supposed to fix 😮

@aggarwalpulkit596
Copy link
Contributor Author

aggarwalpulkit596 commented Aug 15, 2018

@championswimmer it can't be done because they are instrumented test and they need a real device for that 😜 and there is only one unit test
https://github.com/coding-blocks/DigitalOceanApp/blob/master/doandroidlib/src/test/java/in/tosc/doandroidlib/DigitalOceanTest.java

@championswimmer
Copy link
Contributor

yea just run this https://github.com/coding-blocks/DigitalOceanApp/blob/master/doandroidlib/src/test/java/in/tosc/doandroidlib/DigitalOceanTest.java on circleci

I thought you got an error on this test.

@championswimmer
Copy link
Contributor

as in just run test not connectedCheck on circleci

@aggarwalpulkit596
Copy link
Contributor Author

Okay this can be done 👍

@aggarwalpulkit596 aggarwalpulkit596 force-pushed the master branch 6 times, most recently from a406615 to 3f05262 Compare August 17, 2018 16:08
@championswimmer championswimmer merged commit 79f2715 into coding-blocks:master Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants