Skip to content

Fixed NaN values on stats page #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed NaN values on stats page #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions routes/root.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ route.get('/stats', (req, res) => {
res.render('pages/stats', {
participants: data[0],
Copy link
Contributor

@abhishek97 abhishek97 May 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets's do it for all the values

Copy link
Contributor Author

@nikhilhassija nikhilhassija May 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, moved the logic to getCounts functions as it's better to have the check there only. Ref #182

claims: data[1],
accepted: data[2],
totalclaimed: data[3],
accepted: data[2] || 0,
totalclaimed: data[3] || 0,
menu: { stats: 'active' }
})
})
Expand Down