Skip to content

Conversation

@aannaassalam
Copy link
Contributor

I made the navbar of boss website for mobile more reponsive and here are the ScreenShot of those.
Annotation 2020-05-24 004352
Annotation 2020-05-24 004251

@championswimmer @abhishek97 @hereisnaman please review this
Fix for issue #214

@thenamankumar
Copy link
Contributor

@aannaassalam can you add a gif or loom recording?

@thenamankumar
Copy link
Contributor

Also remove public_path and semantic.json changes from diff. Have you tested these changes cross browsers?

@aannaassalam
Copy link
Contributor Author

Can you please help me to remove those changes

@thenamankumar
Copy link
Contributor

Can you please help me to remove those changes

if you are on the latest version of git the following should work:

git reset --soft HEAD~1
git restore -S -W -s HEAD public_static semantic.json

@aannaassalam
Copy link
Contributor Author

Ok I am giving it a try

@aannaassalam
Copy link
Contributor Author

ezgif com-video-to-gif
This is the GIF of the preview

and I made the nessesary changes that you demanded for.
please see to it @hereisnaman

@thenamankumar
Copy link
Contributor

@aannaassalam basically I wanted to see how the leaderboard and claims dropdown are behaving. Can you display that.

@aannaassalam
Copy link
Contributor Author

Offcourse are you comfortable with the changes removed in public_static and semantic as u asked
Is it Ok???

@thenamankumar
Copy link
Contributor

Offcourse are you comfortable with the changes removed in public_static and semantic as u asked
Is it Ok???

I can still see they are not removed from the diff https://github.com/coding-blocks/boss/pull/344/files

@aannaassalam
Copy link
Contributor Author

Ok I am fixing them and also sending you the response of leaderboard and claim option too

@aannaassalam
Copy link
Contributor Author

aannaassalam commented May 23, 2020

ezgif com-video-to-gif
I removed the public_static and semantic.json commit and above is the GIF that you requested for.
please give your reviews that you are impressed or not @hereisnaman

@thenamankumar thenamankumar merged commit 1dcb240 into coding-blocks:master May 23, 2020
@boss-contributions-bot
Copy link

Congratualtions @aannaassalam, your pull request is merged! 🎉

Thanks for your contributions and participating in BOSS 2020. 🙌

You can claim your bounty points here. 💰

@aannaassalam aannaassalam deleted the issue branch May 23, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants