Skip to content

Conversation

@nerg4l
Copy link
Member

@nerg4l nerg4l commented Jun 10, 2020

test request documentation of Resumable.js: https://github.com/23/resumable.js#handling-get-or-test-requests

If the request returns anything else, the chunk will be uploaded in the standard fashion. (It is recommended to return 204 No Content in these cases if possible to avoid unwarranted notices in browser consoles.)

Before the library throw a NotFoundHttpException when the chunk of the file was missing. Now it is returning a 204 No Content response as suggested by the documentation.

@nerg4l nerg4l mentioned this pull request Jun 12, 2020
@nerg4l nerg4l requested a review from a team June 12, 2020 13:10
@nerg4l nerg4l added this to the v0.2.0 milestone Jun 12, 2020
@nerg4l nerg4l added the bug Something isn't working label Jun 12, 2020
@nerg4l nerg4l merged commit 131c778 into coding-socks:master Jun 20, 2020
@nerg4l nerg4l deleted the fix-resumable-js-response-code branch June 20, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant