Skip to content

(feat) added slugs to projects #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 20, 2024
Merged

(feat) added slugs to projects #114

merged 7 commits into from
Aug 20, 2024

Conversation

@benjaminstrasser
Copy link
Member

@benjaminstrasser benjaminstrasser commented Jul 10, 2024 •
edited
Loading

  • added slugs to URL
  • adopted tests
  • wrote slug service
  • added slugs to projects database schema
  • adopted projects service and repository
  • renamed base_language to base_language_id in the database
  • renamed base_language to base_language_code in the form

@benjaminstrasser
Copy link
Member Author

benjaminstrasser commented Jul 10, 2024

One issue that still needs to be discussed.
Some generated slugs will be empty. For example , ! and so on. How do we want to deal with these?
We could simply return a invalid name error to the user. Any input?

mledl
mledl reviewed Jul 12, 2024
View reviewed changes
sjaghori
sjaghori reviewed Jul 19, 2024
View reviewed changes
@benjaminstrasser benjaminstrasser force-pushed the feat/project-slug branch 4 times, most recently from d83570b to 1fb9150 Compare July 23, 2024 13:56
sjaghori
sjaghori previously approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@sjaghori sjaghori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great! The rest also looks fine to me!

@benjaminstrasser benjaminstrasser enabled auto-merge (squash) August 2, 2024 12:23
@benjaminstrasser benjaminstrasser force-pushed the feat/project-slug branch 2 times, most recently from 0510a72 to e2b0434 Compare August 2, 2024 12:37
sjaghori
sjaghori requested changes Aug 4, 2024
View reviewed changes
benjaminstrasser and others added 6 commits August 13, 2024 20:51
@benjaminstrasser @sjaghori
added slugs to projects
3053ed4 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser @sjaghori
renamed slug service and moved dependency
e830035 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser @sjaghori
added slug display to create project
7d12d37 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser @sjaghori
added dynamic check for project name and slug
49653d3 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser @sjaghori
added debounce utility function
a428cb0 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@sjaghori
pr improvement
6a360f4
sjaghori
sjaghori previously approved these changes Aug 13, 2024
View reviewed changes
@sjaghori sjaghori disabled auto-merge August 13, 2024 18:56
@sjaghori
Copy link
Collaborator

sjaghori commented Aug 13, 2024

@mledl can you approve this pr

@benjaminstrasser
updated pnpm-lock.json
890dc3e 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
Copy link
Member Author

benjaminstrasser commented Aug 20, 2024

@sjaghori @mledl
This should be ready now.

@sjaghori sjaghori merged commit 4c1ff75 into main Aug 20, 2024
@sjaghori sjaghori deleted the feat/project-slug branch August 20, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mledl mledl mledl left review comments

@sjaghori sjaghori sjaghori approved these changes

@jjnp jjnp Awaiting requested review from jjnp jjnp is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@benjaminstrasser @sjaghori @mledl