fix: avoid recomputing react context (#684) #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanhofer
reviewed
Jul 8, 2023
Collaborator
ivanhofer
left a comment
ivanhofer
left a comment
There was a problem hiding this comment.
Thanks for opening this PR. I have some questions regarding your changes.
vchirikov
force-pushed
the
fix/react-adapter
branch
from
70d6fd0 to
a85005d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #684
I also include typo fix & eslint auto fixes here and there was a version mismatch between package.json & generated version in
packages/version.ts, I fixed this too.cc: @ivanhofer