Merged
Conversation
🛠️ app/pages/line-plot/page.tsx -> Updated title text
🟢 app/components/BarChart/BarChart.stories.tsx 🟢 app/components/BarChart/BarChart.tsx 🟢 app/components/BarChart/index.ts 🟢 app/components/BarChart/tests/BarChart.test.tsx
…emoved commented code, and simplified main tag.
🛠️ app/components/BarChart/BarChart.tsx -> Implemented useEffect 🛠️ app/components/BarChart/BarChart.tsx -> Added useRef for SVG 🛠️ app/components/BarChart/BarChart.tsx -> Added D3 chart setup 🛠️ app/components/BarChart/BarChart.tsx -> Added CSV data parsing 🛠️ app/components/BarChart/BarChart.tsx -> Added X and Y axes 🛠️ app/components/BarChart/BarChart.tsx -> Added bar rendering
…red data type conversion, and fixed non-null assertion.
🛠️ app/layout.tsx -> Removed Inter font import 🛠️ app/layout.tsx -> Removed Inter font initialization
🛠️ app/pages/bar-chart/page.tsx -> Removed d3 import
…arChart 🛠️ app/components/BarChart/BarChart.tsx -> Minor comment text capitalization 🛠️ app/components/BarChart/BarChart.tsx -> Enhanced SVG selection description comment 🛠️ app/components/BarChart/BarChart.tsx -> Expanded CSV data parsing comment 🛠️ app/components/BarChart/BarChart.tsx -> Added TypeScript ignore comments 🛠️ app/components/BarChart/BarChart.tsx -> Added stroke and stroke-width to bars
…rts and code 🛠️ app/components/BarChart/tests/BarChart.test.tsx -> Commented out imports and code 🛠️ app/components/LinePlot/LinePlot.stories.tsx -> Commented out imports and code 🛠️ app/components/LinePlot/tests/LinePlot.test.tsx -> Commented out imports and code 🛠️ app/components/Menu/Menu.stories.tsx -> Commented out imports and code 🛠️ app/components/Menu/tests/Menu.test.tsx -> Commented out imports and code
🟢 app/components/BarChart/data/countries.json
🛠️ app/components/BarChart/BarChart.tsx -> removed CSV data fetching 🛠️ app/components/BarChart/BarChart.tsx -> used JSON data for chart
🛠️ app/components/BarChart/BarChart.tsx -> Added SVG clearing code 🛠️ app/components/BarChart/BarChart.tsx -> Improved type casting 🛠️ app/components/BarChart/BarChart.tsx -> Dynamically set Y-axis domain 🛠️ app/components/BarChart/BarChart.tsx -> Updated bar selection name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ app/components/BarChart/BarChart.tsx -> Added SVG clearing code
🛠️ app/components/BarChart/BarChart.tsx -> Improved type casting
🛠️ app/components/BarChart/BarChart.tsx -> Dynamically set Y-axis domain
🛠️ app/components/BarChart/BarChart.tsx -> Updated bar selection name