-
-
Notifications
You must be signed in to change notification settings - Fork 1
Use PEP 735 Dependency Groups for testing #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Several tools like `uv` now support dependency groups to separate from other optional-dependencies. Adding the test requirements there. Ideally this would replace the values in [test] but seems like it's only supported in Python 3.13 +
|
Hi @kfdm, Fancy meeting you here! 😄 Would you care to add a If you are busy with other things, no worries. I can give you a hand. Cheers! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 5 5
Lines 134 134
=======================================
Hits 131 131
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We let the dev group include test by default, and move the test group from optional-dependencies to dependency-groups to have a single source of truth.
|
I'll give it a shot and see what I come up with :) |
Instead of our $extras var be a list, we will write it as the combination of --extra ? and no extra flags for uv. Then we can skip the two separate install steps, and run uv using the --with and $extras flags. uv build/publish does not have the same kind of check as `twine check` so that has not been updated yet.
341e69a to
0351f86
Compare
|
I have not touched the build/publish bits since that might be better to test in its own commit due to better test with the github artifcat and pypi-publish actions, but this should cover the pytest bits. |
Several tools like
uvnow support dependency groups to separate from other optional-dependencies. Adding the test requirements there. Ideally this would replace the values in [test] but seems like it's only supported in Python 3.13 +I was hoping I could also use this to simplify the ci.yml as well, but seems like
--groupsfor pip doesn't work in 3.12 only 3.13 >=Had wanted to add this so that a Makefile/Justfile could be added so that
make testorjust testcould trigger pytest more easily, but may need to research it a bit more.Trying to insure that I can easily test locally before I tried to make another PR 🙃