-
-
Notifications
You must be signed in to change notification settings - Fork 4
Move documentation from sphinx to mkdocs #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds branded logo images to the repository and updates the README to display them at the top. The changes enhance the visual presentation of the project documentation by adding a professional logo with support for both light and dark color schemes.
Key Changes
- Added two SVG logo variants (light and dark) to support different display themes
- Updated README.rst to display the logo using HTML picture element for theme-aware rendering
- Repositioned the existing sample.png screenshot to appear after the feature list
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| images/logo-light.svg | New logo SVG file optimized for light theme backgrounds |
| images/logo-dark.svg | New logo SVG file optimized for dark theme backgrounds |
| README.rst | Added HTML raw block with picture element for theme-aware logo display; moved sample.png figure lower in the document |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8267598 to
5e0d2fc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
- Coverage 99.69% 93.33% -6.37%
==========================================
Files 21 21
Lines 332 345 +13
==========================================
- Hits 331 322 -9
- Misses 1 23 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 24 out of 28 changed files in this pull request and generated 14 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| `registration/logged_out.html` | ||
|
|
||
| This template will be displayed after a successful logout. This template | ||
| is not proved Django or by the package and needs to be created. |
Copilot
AI
Dec 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammatical error: "This template is not proved Django or by the package" should be "This template is not provided by Django or by the package".
|
|
||
| ## Setup | ||
|
|
||
| First add `mailauth` to you installed apps: |
Copilot
AI
Dec 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammatical error: "add mailauth to you installed apps" should be "add mailauth to your installed apps".
| - id: mdformat | ||
| additional_dependencies: | ||
| - mdformat-ruff | ||
| - mdformat-ruff |
Copilot
AI
Dec 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate dependency entry: "mdformat-ruff" is listed twice in the additional_dependencies list (lines 29 and line previously removed). This appears to be an error in the migration where line 29 should have been removed instead of line 28.
| - mdformat-ruff |
|
|
||
| ## The sample app | ||
|
|
||
| To run a full example --- e.g. to debug frontend code -- you can run: |
Copilot
AI
Dec 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect punctuation: "e.g. to debug frontend code --" should use a single dash "e.g. to debug frontend code -" instead of three dashes. Three dashes (---) is not standard for this context and may be rendered as an em dash depending on the markdown processor.
| To run a full example --- e.g. to debug frontend code -- you can run: | |
| To run a full example - e.g. to debug frontend code - you can run: |
|
|
||
| def get_login_url(self, request, token, next=None): | ||
| def get_login_url( | ||
| self, request: django.http.request.HttpRequest, token: str, next: str = None |
Copilot
AI
Dec 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type annotation issue: The parameter next should be typed as str | None instead of str = None for better clarity. While str = None works with PEP 484, the modern approach (with from __future__ import annotations) is to use str | None to explicitly indicate optionality.
| self, request: django.http.request.HttpRequest, token: str, next: str = None | |
| self, request: django.http.request.HttpRequest, token: str, next: str | None = None |
| That's it! | ||
|
|
||
| > [!IMPORTANT] | ||
| > Don't forget to setup you Email backend! |
Copilot
AI
Dec 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammatical error: "setup you Email backend" should be "setup your Email backend".
| > Don't forget to setup you Email backend! | |
| > Don't forget to setup your Email backend! |
| [email][mailauth.contrib.user.models.AbstractEmailUser.email] field serves as a username and is -- different to Django's | ||
| User -- unique and case-insensitive. |
Copilot
AI
Dec 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent use of dashes: "is -- different to Django's User --" uses double dashes. Consider using standard em dashes or parentheses for better readability, such as "is (different to Django's User)" or "is—different to Django's User—".
| [email][mailauth.contrib.user.models.AbstractEmailUser.email] field serves as a username and is -- different to Django's | |
| User -- unique and case-insensitive. | |
| [email][mailauth.contrib.user.models.AbstractEmailUser.email] field serves as a username and is—different to Django's | |
| User—unique and case-insensitive. |
| uv run tests/manage.py runserver | ||
| ``` | ||
|
|
||
| Next you can go to <https://localhost:8000/admin/> and log in with your |
Copilot
AI
Dec 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid URL protocol: "https://localhost:8000/admin/" should use "http://localhost:8000/admin/" since localhost typically runs on HTTP by default, not HTTPS.
| Next you can go to <https://localhost:8000/admin/> and log in with your | |
| Next you can go to <http://localhost:8000/admin/> and log in with your |
| the following: | ||
|
|
||
| ```python | ||
| from django.urls import path |
Copilot
AI
Dec 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing import statement: The code example uses include() function but doesn't import it. The import line should be from django.urls import path, include.
| from django.urls import path | |
| from django.urls import path, include |
| `registration/login_requested.html` | ||
|
|
||
| This template will be displayed after a user successfully requested a | ||
| login URL. This template is not proved by the package and needs to be |
Copilot
AI
Dec 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammatical error: "This template is not proved by the package" should be "This template is not provided by the package".
No description provided.