Skip to content

Conversation

@codingjoe
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings December 17, 2025 14:56
@codingjoe codingjoe self-assigned this Dec 17, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds branded logo images to the repository and updates the README to display them at the top. The changes enhance the visual presentation of the project documentation by adding a professional logo with support for both light and dark color schemes.

Key Changes

  • Added two SVG logo variants (light and dark) to support different display themes
  • Updated README.rst to display the logo using HTML picture element for theme-aware rendering
  • Repositioned the existing sample.png screenshot to appear after the feature list

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

File Description
images/logo-light.svg New logo SVG file optimized for light theme backgrounds
images/logo-dark.svg New logo SVG file optimized for dark theme backgrounds
README.rst Added HTML raw block with picture element for theme-aware logo display; moved sample.png figure lower in the document

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codingjoe codingjoe force-pushed the readme branch 2 times, most recently from 8267598 to 5e0d2fc Compare December 17, 2025 15:10
Copilot AI review requested due to automatic review settings December 17, 2025 15:10
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.33%. Comparing base (746ccaa) to head (757a254).
⚠️ Report is 124 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (746ccaa) and HEAD (757a254). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (746ccaa) HEAD (757a254)
7 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
- Coverage   99.69%   93.33%   -6.37%     
==========================================
  Files          21       21              
  Lines         332      345      +13     
==========================================
- Hits          331      322       -9     
- Misses          1       23      +22     
Flag Coverage Δ
python-3.10 93.04% <100.00%> (?)
python-3.11 93.04% <100.00%> (?)
python-3.12 93.04% <100.00%> (?)
python-3.13 93.04% <100.00%> (?)
python-3.14 93.04% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 4 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codingjoe codingjoe changed the title Add image to readme Move documentation from sphinx to mkdocs Dec 17, 2025
@codingjoe codingjoe merged commit 9cc5721 into main Dec 17, 2025
17 of 22 checks passed
@codingjoe codingjoe deleted the readme branch December 17, 2025 18:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 24 out of 28 changed files in this pull request and generated 14 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

`registration/logged_out.html`

This template will be displayed after a successful logout. This template
is not proved Django or by the package and needs to be created.
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical error: "This template is not proved Django or by the package" should be "This template is not provided by Django or by the package".

Copilot uses AI. Check for mistakes.

## Setup

First add `mailauth` to you installed apps:
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical error: "add mailauth to you installed apps" should be "add mailauth to your installed apps".

Copilot uses AI. Check for mistakes.
- id: mdformat
additional_dependencies:
- mdformat-ruff
- mdformat-ruff
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate dependency entry: "mdformat-ruff" is listed twice in the additional_dependencies list (lines 29 and line previously removed). This appears to be an error in the migration where line 29 should have been removed instead of line 28.

Suggested change
- mdformat-ruff

Copilot uses AI. Check for mistakes.

## The sample app

To run a full example --- e.g. to debug frontend code -- you can run:
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect punctuation: "e.g. to debug frontend code --" should use a single dash "e.g. to debug frontend code -" instead of three dashes. Three dashes (---) is not standard for this context and may be rendered as an em dash depending on the markdown processor.

Suggested change
To run a full example --- e.g. to debug frontend code -- you can run:
To run a full example - e.g. to debug frontend code - you can run:

Copilot uses AI. Check for mistakes.

def get_login_url(self, request, token, next=None):
def get_login_url(
self, request: django.http.request.HttpRequest, token: str, next: str = None
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type annotation issue: The parameter next should be typed as str | None instead of str = None for better clarity. While str = None works with PEP 484, the modern approach (with from __future__ import annotations) is to use str | None to explicitly indicate optionality.

Suggested change
self, request: django.http.request.HttpRequest, token: str, next: str = None
self, request: django.http.request.HttpRequest, token: str, next: str | None = None

Copilot uses AI. Check for mistakes.
That's it!

> [!IMPORTANT]
> Don't forget to setup you Email backend!
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical error: "setup you Email backend" should be "setup your Email backend".

Suggested change
> Don't forget to setup you Email backend!
> Don't forget to setup your Email backend!

Copilot uses AI. Check for mistakes.
Comment on lines +84 to +85
[email][mailauth.contrib.user.models.AbstractEmailUser.email] field serves as a username and is -- different to Django's
User -- unique and case-insensitive.
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent use of dashes: "is -- different to Django's User --" uses double dashes. Consider using standard em dashes or parentheses for better readability, such as "is (different to Django's User)" or "is—different to Django's User—".

Suggested change
[email][mailauth.contrib.user.models.AbstractEmailUser.email] field serves as a username and is -- different to Django's
User -- unique and case-insensitive.
[email][mailauth.contrib.user.models.AbstractEmailUser.email] field serves as a username and isdifferent to Django's
Userunique and case-insensitive.

Copilot uses AI. Check for mistakes.
uv run tests/manage.py runserver
```

Next you can go to <https://localhost:8000/admin/> and log in with your
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid URL protocol: "https://localhost:8000/admin/" should use "http://localhost:8000/admin/" since localhost typically runs on HTTP by default, not HTTPS.

Suggested change
Next you can go to <https://localhost:8000/admin/> and log in with your
Next you can go to <http://localhost:8000/admin/> and log in with your

Copilot uses AI. Check for mistakes.
the following:

```python
from django.urls import path
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing import statement: The code example uses include() function but doesn't import it. The import line should be from django.urls import path, include.

Suggested change
from django.urls import path
from django.urls import path, include

Copilot uses AI. Check for mistakes.
`registration/login_requested.html`

This template will be displayed after a user successfully requested a
login URL. This template is not proved by the package and needs to be
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical error: "This template is not proved by the package" should be "This template is not provided by the package".

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants