Skip to content

Conversation

@codingjoe
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings December 18, 2025 00:13
@codingjoe codingjoe self-assigned this Dec 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the CI/CD infrastructure by migrating from traditional pip-based workflows to UV-based GitHub Actions, and consolidates linting tools from multiple separate tools (black, flake8, isort, pydocstyle, bandit) into Ruff.

Key changes:

  • Migrated GitHub Actions workflows to use UV for faster dependency management and builds
  • Replaced multiple Python linting tools with Ruff (configured in pyproject.toml)
  • Added pre-commit configuration for automated code quality checks
  • Reformatted code according to Ruff standards (f-strings, quote styles, formatting)

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
.github/workflows/ci.yml Migrated to UV-based actions, removed separate py-lint job, removed CodeQL analysis
.github/workflows/release.yml Simplified release workflow using UV and trusted publishing
pyproject.toml Added comprehensive Ruff configuration, migrated from isort/pydocstyle configs, changed to dependency-groups
.pre-commit-config.yaml Added pre-commit hooks for Ruff, pyupgrade, django-upgrade, mdformat
setup.cfg Removed (flake8 config no longer needed)
linter-requirements.txt Removed (replaced by Ruff in dependency groups)
tests/*.py Reformatted with f-strings and consistent formatting
s3file/*.py Updated comment style, bandit noqa markers, f-strings
README.md Fixed escaped apostrophes, reformatted lists and code blocks
SECURITY.md Removed (security policy moved elsewhere)
MANIFEST.in Removed (no longer needed)
.github/FUNDING.yml Removed
.github/dependabot.yml Reformatted indentation
LICENSE Removed trailing newline

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- run: python -m pip install -e .[test]
- run: python -m pytest -m selenium
- run: uv run --with django~=${{ matrix.django-version }}.0 pytest -m selenium
- uses: codecov/codecov-action@v5
Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Django version specification for the selenium job. The pytest job on line 74 includes --with django~=${{ matrix.django-version }}.0 but the selenium job on line 101 is missing this specification. This could lead to inconsistent test environments between the two jobs.

Copilot uses AI. Check for mistakes.


- uses: actions/checkout@v6
- uses: astral-sh/setup-uv@v7
Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checkout action version is inconsistent. Line 61 uses actions/checkout@v5 while line 11 uses actions/checkout@v6. Both instances should use the same version for consistency.

Copilot uses AI. Check for mistakes.
@codingjoe codingjoe force-pushed the uv branch 4 times, most recently from bcf0be4 to 802e2bf Compare December 18, 2025 00:26
@codingjoe codingjoe merged commit 626d77e into main Dec 18, 2025
13 of 14 checks passed
@codingjoe codingjoe deleted the uv branch December 18, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants