Skip to content

Switch from Standardjs to Prettier #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codingjoe merged 2 commits into from
Dec 18, 2025
Merged

Switch from Standardjs to Prettier #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d8a3d6
Switch from Standardjs to Prettier
codingjoe Dec 18, 2025
8d09697
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,8 @@ jobs:
- uses: actions/upload-artifact@v6
with:
path: dist/*
js-lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version-file: .nvmrc
- name: Install Node dependencies
run: npm ci
- run: npm run lint:js
js-test:
runs-on: ubuntu-latest
needs:
- js-lint
steps:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
Expand Down
10 changes: 10 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,16 @@ repos:
rev: v0.20.0
hooks:
- id: yamlfmt
- repo: local
hooks:
- id: prettier
name: prettier
entry: prettier --check --write --ignore-unknown
Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pre-commit hook configuration uses both "--check" and "--write" flags together. These flags are contradictory: "--check" is for checking formatting without modifying files (exits with error if files need formatting), while "--write" modifies files in place. For a pre-commit hook, you should use only "--check" to verify formatting, or only "--write" to automatically format files, but not both.

Suggested change
entry: prettier --check --write --ignore-unknown
entry: prettier --check --ignore-unknown

Copilot uses AI. Check for mistakes.
args:
- --config=package.json
language: node
Comment on lines +47 to +49
Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "args" configuration is redundant because "--config=package.json" is already being passed in the "entry" field. This duplication could cause the config argument to be passed twice, potentially leading to unexpected behavior.

Copilot uses AI. Check for mistakes.
additional_dependencies: ["prettier"]
types_or: [javascript]
ci:
autoupdate_schedule: weekly
skip:
Expand Down
Loading
Loading