Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 18, 2025

Property name typo pendingRquests prevented the form submission handler from correctly waiting on pending upload requests.

Changes

  • Source code: Fixed pendingRquestspendingRequests in submitHandler() and uploadHandler() methods
  • Tests: Updated test assertions to use correct property name

The typo caused Promise.all() to wait on undefined instead of the actual pending requests array, breaking the upload flow in Safari's custom element implementation.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: codingjoe <1772890+codingjoe@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on Safari support implementation Fix typo: pendingRquests → pendingRequests Dec 18, 2025
Copilot AI requested a review from codingjoe December 18, 2025 19:39
Copy link
Owner

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.20%. Comparing base (2218cd3) to head (8730363).
⚠️ Report is 1 commits behind head on safari.

Additional details and impacted files
@@           Coverage Diff           @@
##           safari     #360   +/-   ##
=======================================
  Coverage   98.20%   98.20%           
=======================================
  Files           8        8           
  Lines         223      223           
=======================================
  Hits          219      219           
  Misses          4        4           
Flag Coverage Δ
python 98.20% <ø> (ø)
selenium-ubuntu-latest 82.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codingjoe codingjoe marked this pull request as ready for review December 18, 2025 19:41
Copilot AI review requested due to automatic review settings December 18, 2025 19:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical typo in the property name used to track pending upload requests, changing pendingRquests to pendingRequests. The typo caused Promise.all() to wait on undefined instead of the actual pending requests array, breaking the upload flow in Safari's custom element implementation.

  • Fixed the typo in the submitHandler() method where pending requests are awaited
  • Fixed the typo in the uploadHandler() method where the pending requests array is initialized and populated
  • Updated test assertions to use the corrected property name

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
s3file/static/s3file/js/s3file.js Fixed the typo in both submitHandler() (line 220) and uploadHandler() (lines 227-228) methods to correctly reference pendingRequests
tests/tests/s3file.test.js Updated test setup (line 58) and assertion (line 85) to use the corrected property name pendingRequests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codingjoe codingjoe merged commit 5715ff8 into safari Dec 18, 2025
21 of 22 checks passed
@codingjoe codingjoe deleted the copilot/sub-pr-357-another-one branch December 18, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants