Flatten aws.logging.ivs to aws.ivs, add IVS docs#20
Merged
stevethomas merged 5 commits intomainfrom May 5, 2026
Merged
Conversation
The aws.logging.* wrapper was the wrong shape — YOLO's manifest is organised by AWS service (aws.ec2, aws.cloudfront, aws.mediaconvert), not by cross-cutting category. Flatten to aws.ivs, no back-compat. The sync:logging CLI command and Steps\Logging namespace stay as deliberately broad umbrella names. README and docs gain IVS coverage including a new aws.ivs entry in the manifest reference and sync:logging in the provisioning guide. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Reference docs (commands.md) describe what sync:logging does today (IVS state-change logging); the higher-level provisioning guide should stay generic so it doesn't need an edit every time another logging step lands. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Match the provisioning guide — the umbrella command's description shouldn't need to enumerate every step it runs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The aws.ivs manifest key now accepts two forms: - Boolean shorthand (aws.ivs: true) — enables logging with the default 14-day retention. - Expanded map (aws.ivs.logging: bool, aws.ivs.log-retention-days: int) — read directly so users can disable logging while keeping room for future IVS attributes alongside it. The three sync steps now gate on Manifest::ivsLoggingEnabled() which unifies both forms. Retention lookup is unchanged; Arr::get falls back to 14 against the boolean shorthand and reads the explicit override against the map form. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Logging is the only IVS feature today, so the longer name was defensive against a future that may never arrive. Rename when a second IVS feature lands. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aws.logging.ivstoaws.ivs(andaws.ivs.log-retention-daysfor the optional retention override). No back-compat —aws.logging.*was the wrong shape since YOLO's manifest is organised by AWS service, not cross-cutting category.sync:loggingCLI command andCodinglabs\Yolo\Steps\LoggingPHP namespace stay as deliberately broad umbrella names — sync buckets are intentionally broader than the manifest service taxonomy, so they don't 1:1 mirror manifest keys.aws.ivsKey Options entry in the manifest reference, andsync:loggingin the provisioning guide + commands reference.Test plan
./vendor/bin/pint— clean./vendor/bin/phpstan analyse --memory-limit=1G— no errors./vendor/bin/pest— 48/48 passedgrep -rn 'aws.logging.ivs' src/ tests/ docs/ README.md— zero matches🤖 Generated with Claude Code