Accept hostname targets that do not contain a period. #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue codingo#123, which was due to a misinterpretation of the line `if host.split(".")[0][0].isalpha() or host.split(".")[-1][-1].isalpha():` (see commit 8d46d14, L156). Because of how Python's str.split() works, a hostname that does not contain a period when .split(".") results in a single-item list, so this expression evaluates to True. However, this also means that the .split()s had no effect: the line was equivalent to `if host[0].isalpha() or host[-1].isalpha()`.
Collaborator
|
Sorry for taking so long! This was a very necessary bug fix! You're a legend mate @whiteroses! |
Contributor
Author
|
@prodigysml Sorry again for the bug, and thanks for merge and maintenance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #123, which was due to a misinterpretation of the
line
if host.split(".")[0][0].isalpha() or host.split(".")[-1][-1].isalpha():(see L156 of
input.pyafter commit 8d46d14/before commit d1c90a4). Because ofhow Python's
str.split()works, a hostname that does not contain aperiod when
.split(".")results in a single-item list, so thisexpression evaluates to
True. However, this also means that the.split()s had no effect: the line was equivalent toif host[0].isalpha() or host[-1].isalpha().