Cleanup, added logger statements where needed and overhauled the options menu#10
Merged
tcstool merged 2 commits intocodingo:Devfrom Dec 17, 2013
Merged
Cleanup, added logger statements where needed and overhauled the options menu#10tcstool merged 2 commits intocodingo:Devfrom
tcstool merged 2 commits intocodingo:Devfrom
Conversation
tcstool
added a commit
that referenced
this pull request
Dec 17, 2013
Cleanup, added logger statements where needed and overhauled the options menu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've cleaned up the syntax and spacing again for consistency, merged some newlines.
Added Logger.error() in a few places where a custom exception was raised with no feedback.
Most significantly I refactored the menu in options.py. Instead of a huge if-elif block, it's now a cleaner Python dictionary that takes callables as values. Only "back to main menu" is now an if statement, since the return statement needs to be in that scope to work properly.