Skip to content

fix wrong ordering #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2021
Merged

fix wrong ordering #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7724f85
fix wrong ordering
deep-diver Jul 4, 2021
aae2ba3
Update client/lib/sort_preference.dart
deep-diver Jul 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions client/lib/screens/main_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ class _MainScreenState extends State<MainScreen> {
children: [
MainScreenListView(
cleanList: sort.isDescOrder
? cleanList
: List.from(cleanList.reversed)),
? List.from(cleanList.reversed)
: cleanList),
MainScreenFavoriteView(
cleanList: sort.isDescOrder
? cleanList
: List.from(cleanList.reversed))
? List.from(cleanList.reversed)
: cleanList)
],
),
bottomNavigationBar: CustomBottomNavigationBar(
Expand Down
4 changes: 2 additions & 2 deletions client/lib/sort_preference.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import 'package:shared_preferences/shared_preferences.dart';
const _sharedPreferenceSortModeKey = "isDescOrder";

class SortMode extends ChangeNotifier {
bool _isDescOrder = false;
bool _isDescOrder = true;

bool get isDescOrder {
return _isDescOrder;
Expand All @@ -26,7 +26,7 @@ class SortMode extends ChangeNotifier {

// This type should not be a widget(e.g. Icon) because of mockito support...
IconData get icon =>
_isDescOrder ? Icons.vertical_align_top : Icons.vertical_align_bottom;
_isDescOrder ? Icons.arrow_upward : Icons.arrow_downward;

// This type should not be a widget(e.g. Text) because of mockito support...
String get text => _isDescOrder ? "오름차순으로" : "내림차순으로";
Expand Down